Skip to content

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 14, 2026

Fixes #485

This fixes the remaining pre-commit errors on main, so we can start enforcing it on PR CI.

Happy to say actionlint caught a couple of issues in inline shell scripts here 😁

Notes for Reviewers

If this is approved, once it's merged I'll update the branch protections to make the pre-commit.ci workflow required to merge.

@jameslamb jameslamb requested a review from a team as a code owner January 14, 2026 21:12
@jameslamb jameslamb added the improvement Improves an existing functionality label Jan 14, 2026
@jameslamb jameslamb requested review from bdice and removed request for a team January 14, 2026 21:12
@jameslamb jameslamb added the non-breaking Introduces a non-breaking change label Jan 14, 2026
@jameslamb jameslamb marked this pull request as draft January 14, 2026 21:13
@jameslamb jameslamb changed the title enforce pre-commit checks in CI WIP: enforce pre-commit checks in CI Jan 14, 2026
@jameslamb jameslamb removed the request for review from bdice January 14, 2026 21:13
@jameslamb jameslamb changed the title WIP: enforce pre-commit checks in CI WIP: fix pre-commit errors Jan 14, 2026
@jameslamb jameslamb changed the title WIP: fix pre-commit errors fix pre-commit errors Jan 14, 2026
@jameslamb jameslamb marked this pull request as ready for review January 14, 2026 21:17
@jameslamb jameslamb requested review from a team and msarahan and removed request for a team January 14, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'zizmor' checks in CI

2 participants